Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finalize NC ble_v2 flag. #3173

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
+4 −5
Draft

Finalize NC ble_v2 flag. #3173

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions connections/implementation/flags/nearby_connections_feature_flags.h
View file
Original file line number Diff line number Diff line change
@@ -39,7 +39,7 @@ constexpr auto kEnableAutoReconnect =
flags::Flag<bool>(kConfigPackage, "45427690", false);
// Disable/Enable BLE v2 in Nearby Connections SDK.
constexpr auto kEnableBleV2 =
flags::Flag<bool>(kConfigPackage, "45401515", false);
flags::Flag<bool>(kConfigPackage, "45401515", true);
// Disable/Enable GATT query in thread in BLE V2.
// Manual edit: setting this to false for ChromeOS rollout as well.
constexpr auto kEnableGattQueryInThread =
@@ -68,10 +68,9 @@ constexpr auto kMediumDefaultMaxTransmitPacketSize =
// Default max allowed read bytes for medium.
constexpr auto kMediumMaxAllowedReadBytes =
flags::Flag<int64_t>(kConfigPackage, "45669530", 1048576);
// Enable/Disable payload-received-ack feature.
// Set the safe-to-disconnect version.
// Enable 1. safe-to-disconnect check 2. reserved 3. auto-reconnect 4.
// auto-resume 5. non-distance-constraint-recovery 6. payload_ack
// Indicates protocol version for safe-to-disconnect.0. Disabled all. 1.
// safe-to-disconnect 2. reserved 3. auto-reconnect4. auto-resume for dev
// device 5. payload_ack
constexpr auto kSafeToDisconnectVersion =
flags::Flag<int64_t>(kConfigPackage, "45425841", 0);
// When true, use stable endpoint ID.