Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: resolves browser test failures on Mac #628

Closed

Conversation

allison-truhlar
Copy link

Addresses issue #627.

  • Adds playwright as a dependency; removes webdriverio.
  • Configures Vitest to use playwright as the browser provider rather than webdriverio.
  • Adds npx playwright install to the test and test:watch commands in package.json. This is to ensure playwright updates after the initial install, to avoid getting the error Error: browserType.launch, followed the by the instructions: "Looks like Playwright Test or Playwright was just installed or updated. Please run the following command to download new browsers: npx playwright install.

All tests pass in macOS 14.5 using this configuration.

I haven't completed the Google CLA yet - I am opening this as a draft as I wait for instructions on how to complete it at Janelia.

Copy link

google-cla bot commented Jul 31, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@allison-truhlar
Copy link
Author

Closing this pull request to redo the commits with the correct email address associated for the CLA.

@jbms
Copy link
Collaborator

jbms commented Aug 1, 2024

FYI you can always just force push to the same branch without creating a new pull request

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants