fix(url_hash_bindings): added debouce maxWait value for throttledSetUrlHash #644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rlHash without a maxWait value, debounce can cause important state changes to be lost if there is high rate of state change between the important change and a page reload mouse movement causes state changes and is probably the main reason this can happen
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
without a maxWait value, debounce can cause important state changes to be lost if there is high rate of state change between the important change and a page reload
mouse movement causes state changes and is probably the main reason this can happen. I just threw in a value of double the debounce delay.
Alternatively, we could use throttle with the trailing option set to true. This should give the same behavior as using a maxWait value of updateDelayMilliseconds but maxWait allows more control with performance tuning.