Fix vite example #687
Merged
Fix vite example #687
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This avoids pulling in unnecessary transitive dependencies, and avoids issues the vite dev-server has with transitive CommonJS dependencies.
…nstall The vite examples previously worked only when using a symlinked Neuroglancer (as in the tests used in this repo), but not when the Neuroglancer dependency was installed normally. The vite dev server special-cases symlinked dependencies in a way that made its optimizeDeps step work when Neuroglancer is symlinked in `node_modules` but not otherwise. Additional optimizeDeps options have now been added to the vite example configs to ensure the build works when Neuroglancer is installed as a normal dependency. Fixes #683
jbms
force-pushed
the
fix-vite-example
branch
from
2955f79 to
e9c5fa6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.