Respect uidattr when writing out matching group #151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `uidattr` feature was not considered when writing out the matching group for a particular user. This change adds this missing feature to the group logic. Fixed: google#150
|
Can you add a unit test please? |
|
I could use a pointer on how to unit test this properly. I've tried adding (what I thought should catch this) in ldapsource_test.py by cloning testGetGroupMapAsUser, changing uid and adding a name attr as well as uidattr, but it seems to work without my fix. However, empirically, when I run without the fix, |
|
I'd expect that approach to work, but also I am certain that the mock style
here is very old and difficult.
If you've tested this in your environment I'll take it as it is.
…On Tue, 26 July 2022, 08:44 Alex Chernyakhovsky, ***@***.***> wrote:
I could use a pointer on how to unit test this properly. I've tried adding
(what I thought should catch this) in ldapsource_test.py by cloning
testGetGroupMapAsUser, changing uid and adding a name attr as well as
uidattr, but it seems to work without my fix. However, empirically, when I
run without the fix, /etc/group.cache contains the wrong value. So
clearly I'm not understanding something about how the mocking is working.
—
Reply to this email directly, view it on GitHub
<#151 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAXFX63RVOXJFURKURBOK4TVV4KDZANCNFSM54TRDR5A>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
|
Yeah, I've tested this empirically with a local checkout. I'm happy to continue working on a unit test, but definitely would appreciate this being merged so I can also ask debian to do a cherry pick |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
uidattrfeature was not considered when writing out the matchinggroup for a particular user. This change adds this missing feature to
the group logic.
Fixed: #150