Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass force_write on FullUpdates #162

Merged
merged 4 commits into from
Oct 20, 2022

Conversation

kozl
Copy link

@kozl kozl commented Oct 16, 2022

Hi! Thank you for this very useful tool. I suppose, I found a bug.
Steps to reproduce it:

  1. No entries in source (LDAP in my case)
  2. Full update with force flag (nsscache --config-file=/etc/nsscache.conf update --full --force-write)
  3. Even with force-write flag provided it can't update cache because of an empty map

I looked in source code and found that force_flag doesn't get passed into WriteMap function.

@google-cla
Copy link

google-cla bot commented Oct 16, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@kozl
Copy link
Author

kozl commented Oct 16, 2022

Signed the Google CLA

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@jaqx0r
Copy link
Contributor

jaqx0r commented Oct 17, 2022

Thanks for this! I'd love to see some test coverage for trying to do a full update with an empty source map.

@kozl
Copy link
Author

kozl commented Oct 20, 2022

Done

@jaqx0r
Copy link
Contributor

jaqx0r commented Oct 20, 2022

Thanks!

@github-actions

This comment has been minimized.

@jaqx0r
Copy link
Contributor

jaqx0r commented Oct 20, 2022

Can you please yapf-format the new tests, and then looks good to go!

@kozl
Copy link
Author

kozl commented Oct 20, 2022

@github-actions

This comment has been minimized.

@jaqx0r jaqx0r merged commit babb138 into google:main Oct 20, 2022
@github-actions
Copy link
Contributor

Unit Test Results

    1 files  ±0      1 suites  ±0   2s ⏱️ -1s
294 tests +1  283 ✔️ +2  11 💤  - 1  0 ❌ ±0 

Results for commit babb138. ± Comparison against base commit ff14b97.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants