-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pass force_write on FullUpdates #162
Pass force_write on FullUpdates #162
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Signed the Google CLA |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Thanks for this! I'd love to see some test coverage for trying to do a full update with an empty source map. |
Done |
Thanks! |
This comment has been minimized.
This comment has been minimized.
Can you please |
✅ |
Hi! Thank you for this very useful tool. I suppose, I found a bug.
Steps to reproduce it:
I looked in source code and found that force_flag doesn't get passed into WriteMap function.