Add gcssource to source factory and nsscache.conf.5 #180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…vered after running it in the test container.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
… into util class to reuse them in gcssource.py.
This comment has been minimized.
This comment has been minimized.
These will be reused in the GCS source, since the GCS API returns datetime objects like the S3 API.
This comment has been minimized.
This comment has been minimized.
…dified timestamp.
This comment has been minimized.
This comment has been minimized.
jaqx0r
approved these changes
Apr 21, 2023
Unit Test Results 1 files 1 suites 2s ⏱️ Results for commit cfe5422. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found "since" is a required attribute on Get*Map methods, but how GCS handles last modified doesn't initially look comparable to HTTP and S3, so it is effectively unused for now.
Manually tested in a modified version of the integration test container and I was able to download passwd, shadow, and group files from a GCS bucket.