Fix resetting of cookie #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
|
CLA signed |
|
CLAs look good, thanks! |
|
There's no bug linked, and no test to show what it's doing; what prompted the change? Can you please write some more in the PR description or in the code about why we need this? |
jaqx0r
reviewed
Nov 2, 2017
nss_cache/sources/ldapsource.py
Outdated
| @@ -301,7 +301,8 @@ def __iter__(self): | |||
| self.message_id, all=0, timeout=self.conf['timelimit']) | |||
| # else: An empty cookie means we are done. | |||
|
|
|||
| # break loop once result3 doesn't time out | |||
| # break loop once result3 doesn't time out and reset cookie | |||
| setCookieOnControl(self.ldap_controls,'',self.PAGE_SIZE) | |||
There was a problem hiding this comment.
space after commas please; use pylint to check style.
|
OK, thanks for the extra info. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When performing multiple searches in the same area (such as auto fs), if the result is bigger than the page size for the first search, the cookie is not reset for the subsequent search.