-
Notifications
You must be signed in to change notification settings - Fork 572
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Oboe 1.6 shared libraries are 6 times smaller than 1.5 binaries #1301
Comments
Running Bloaty diff (which incidentally has the best library name ever) shows the following:
Clearly there's a smoking gun with the debug information. |
And the lack of debug info corresponds to our build script, specifically the following cmake argument:
This will cause all debug info to be stripped from the resulting libraries, which explains the smaller file size. This build script hasn't changed recently though so it doesn't explain why earlier releases do contain debug information. This is likely due to using an updated version of Either way, there's nothing wrong with our libraries (aside from the lack of debug information). 2 conclusions: #1 Oboe should be compiled with |
Not so much a bug as an enormous improvement in library size with an unknown reason. These file sizes are for the arm64 ABI of liboboe.so:
version 1.5: 2.23Mi
version 1.6: 426Ki
That's a 5.75X reduction, and afaik nothing changed on our end.
The instrumented tests all pass, so either we don't have test coverage for an area which will now fail, something changed in our build config, or something changed in the NDK.
Investigation to follow.
The text was updated successfully, but these errors were encountered: