Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

including <android/ndk-version.h> causes build problems with Android #1358

Closed
philburk opened this issue Jul 22, 2021 · 2 comments · Fixed by #1359
Closed

including <android/ndk-version.h> causes build problems with Android #1358

philburk opened this issue Jul 22, 2021 · 2 comments · Fixed by #1359
Assignees
@philburk
Milestone
V1.6.1

Comments

@philburk
Copy link
Collaborator

It does not seem necessary so we can remove it.
This will also prevent a merge conflict in Android /external because it was already removed there.
@philburk philburk added this to the V1.6.1 milestone Jul 22, 2021
@philburk philburk self-assigned this Jul 22, 2021
@philburk
Copy link
Collaborator Author

The NDK_MAJOR is defined in ndk-version.h.
It is used to enable the static asserts in AAudioLoader.cpp.
Those still seem to be getting run. So just removing the include seems OK.

philburk added a commit that referenced this issue Jul 22, 2021
@philburk
oboe: remove include of ndk-version.h
d09f637 
This is to prevent a merge conflict with Android /external/oboe.
It does not seem necessary. __NDK_MAJOR__ is getting defined somewhere else.

Fixes #1358
@philburk philburk mentioned this issue Jul 22, 2021
Merged
dturner pushed a commit that referenced this issue Jul 22, 2021
@philburk @dturner
oboe: remove include of ndk-version.h
911a3e9 
This is to prevent a merge conflict with Android /external/oboe.
It does not seem necessary. __NDK_MAJOR__ is getting defined somewhere else.

Fixes #1358
@philburk
Copy link
Collaborator Author

philburk commented Oct 7, 2021

See also: https://android-review.googlesource.com/c/platform/external/oboe/+/1847358/-1..1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@philburk philburk

Labels
None yet
Projects
None yet
Milestone
V1.6.1
Development

Successfully merging a pull request may close this issue.

oboe: remove include of ndk-version.h google/oboe
1 participant
@philburk