New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FullDuplexStream should use shared_ptr #2033

Closed

philburk opened this issue Jun 11, 2024 · 1 comment · Fixed by #2034

Assignees

Collaborator

philburk commented Jun 11, 2024

The setInputStream() method takes a raw stream pointer.
We should deprecate that and add a method that takes a shared_ptr.

oboe/include/oboe/FullDuplexStream.h

Line 60 in da4de45

void setInputStream(AudioStream *stream) {

philburk assigned robertwu1

Collaborator Author

philburk commented Jun 11, 2024

Also update /tests/testFullDuplexStream.cpp

robertwu1 mentioned this issue

FullDuplexStream: deprecate raw pointers when setting streams #2034

Merged

robertwu1 closed this as completed in #2034

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment