Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FullDuplexStream: deprecate raw pointers when setting streams #2034

Merged
merged 6 commits into from
Jun 25, 2024

Conversation

robertwu1
Copy link
Collaborator

@robertwu1 robertwu1 commented Jun 11, 2024

Fixes #2033, #2038

@robertwu1 robertwu1 requested a review from philburk June 11, 2024 23:40
include/oboe/FullDuplexStream.h Show resolved Hide resolved
include/oboe/FullDuplexStream.h Outdated Show resolved Hide resolved
@robertwu1 robertwu1 requested a review from philburk June 13, 2024 18:17
include/oboe/FullDuplexStream.h Outdated Show resolved Hide resolved
@robertwu1 robertwu1 requested a review from philburk June 20, 2024 23:30
@robertwu1 robertwu1 merged commit fae46d4 into main Jun 25, 2024
3 checks passed
@robertwu1 robertwu1 deleted the robertwu/fullduplexstreamdeprecaterawpointers branch June 25, 2024 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FullDuplexStream should use shared_ptr
2 participants