oboe: improve DataCallbackResult::Stop handling #1351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use another thread to stop the stream for R and earlier. Fixes #1230. Test: use OboeTester "callback return STOP" checkbox
robertwu1
approved these changes
Jul 19, 2021
dturner
approved these changes
Jul 20, 2021
philburk
commented
Jul 20, 2021
|
Yes, we need unit tests. I think a see a bug that would have been found with a unit test. |
Also do not show logcat if app build fails.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use another thread to stop the stream for R and earlier.
Fixes #1230.
Test: use OboeTester "callback return STOP" checkbox