-
Notifications
You must be signed in to change notification settings - Fork 572
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tests: Fix unit tests so all tests pass #1580
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robertwu1
changed the title
Tests: Update UnitTestRunner to Android T
Tests: Fix unit tests so all tests pass
Jul 30, 2022
philburk
reviewed
Jul 30, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work!
robertwu1
commented
Jul 30, 2022
robertwu1
commented
Jul 30, 2022
robertwu1
commented
Jul 30, 2022
robertwu1
commented
Jul 30, 2022
robertwu1
commented
Jul 30, 2022
robertwu1
commented
Jul 30, 2022
robertwu1
commented
Jul 30, 2022
robertwu1
commented
Jul 30, 2022
philburk
approved these changes
Aug 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1501
Fixes #933
Fixes #1103
Fixes #772
Fixes #346
Fixes #232
In the last couple of Android releases, file permissions have become very tight. Before, we were moving the binary to a specific location, giving execute privileges to it, and running it directly in Java. This method is clearly risky and is blocked.
In order to upgrade the UnitTestRunner app, the following was done.
The old method is still used for Android N and below.
A couple of other quality of life changes were added in this PR:
All the Android emulators and real phones I tested with pass with the changes.
One of the test failures is actually a code failure in OpenSL ES. I have opened #1582 to fix this.