Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

opensles: implement capacity using buffer queue length #1601

Merged
merged 4 commits into from
Aug 30, 2022
Merged

opensles: implement capacity using buffer queue length #1601

merged 4 commits into from
Aug 30, 2022

Conversation

philburk
Copy link
Collaborator

@philburk philburk commented Aug 6, 2022

The OpenSL ES buffer queue length controls the allocated size of
the internal buffer. So we can use that to make sure there is enough
capacity to protect against glitches when setting a callback size
or a high capacity.

Fixes #744
It might help with #952

@philburk
opensles: implement capacity using buffer queue length
0b28c1a 
The OpenSL ES buffer queue length controls the allocated size of
the internal buffer. So we can use that to make sure there is enough
capacity to protect against glitches when setting a callback size
or a high capacity.

Fixes #744
It might help with #952
@philburk philburk requested review from flamme and robertwu1 August 6, 2022 23:59
robertwu1
robertwu1 requested changes Aug 8, 2022
View reviewed changes
Copy link
Collaborator

@robertwu1 robertwu1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some comments. Thanks!

@philburk
Cleanup.
2de2caf 
Bump to version 1.6.4
@robertwu1
Copy link
Collaborator

Feel free to submit once you addressed my remaining comments.

@robertwu1
Copy link
Collaborator

LGTM!

@philburk philburk merged commit d0645d6 into main Aug 30, 2022
@philburk philburk deleted the opsl_cap_744 branch August 30, 2022 00:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robertwu1 robertwu1 robertwu1 approved these changes

@flamme flamme Awaiting requested review from flamme

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Adjust OpenSL ES buffer queue length based on capacity
2 participants
@philburk @robertwu1