Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add privacy sensitive mode for API 30+ #1751

Merged
merged 7 commits into from
Mar 24, 2023
Merged

Conversation

robertwu1
Copy link
Collaborator

setPrivacySensitive/isPrivacySensitive are APIs in AAudio for overriding the default input presets. We are adding them to Oboe here.

Instead of using a boolean like in AAudio, Oboe is using a tristate of Unspecified/Enabled/Disabled. This allows a default implementation to be used and a fallback pattern for OpenSLES. Under the hood, AAudio also uses a tristate for this.

Fixes #1093

@robertwu1 robertwu1 requested a review from philburk March 14, 2023 22:49
include/oboe/AudioStreamBuilder.h Outdated Show resolved Hide resolved
include/oboe/Definitions.h Outdated Show resolved Hide resolved
src/aaudio/AAudioLoader.h Show resolved Hide resolved
tests/testStreamOpen.cpp Outdated Show resolved Hide resolved
tests/testStreamOpen.cpp Show resolved Hide resolved
@robertwu1 robertwu1 requested a review from philburk March 16, 2023 23:15
tests/testStreamOpen.cpp Outdated Show resolved Hide resolved
tests/testStreamOpen.cpp Outdated Show resolved Hide resolved
@robertwu1 robertwu1 requested a review from philburk March 17, 2023 17:40
@robertwu1 robertwu1 merged commit 79f9d8f into main Mar 24, 2023
@robertwu1 robertwu1 deleted the robertwu/privacysensitivemode branch March 24, 2023 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support overriding input stream privacy sensitivity
2 participants