Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OboeTester: Fix test disconnect skips #1933

Merged
merged 1 commit into from
Oct 20, 2023

Conversation

robertwu1
Copy link
Collaborator

Fixes several bugs relating to skip and failed buttons.

  1. Pressing the skip button would make the test act like it failed.
  2. The skip and failed buttons would sometimes be disabled between tests.
  3. Pressing the failed button wouldn't do anything at the start of a test.

Fixes #1932

@robertwu1 robertwu1 requested a review from philburk October 20, 2023 16:58
@robertwu1 robertwu1 merged commit e51332f into main Oct 20, 2023
3 checks passed
@robertwu1 robertwu1 deleted the robertwu/oboetesterfixtestdisconnectskip branch October 20, 2023 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Oboe Tester - Test Disconnect - Skip the test will leave a "Failed" message in status area
2 participants