-
Notifications
You must be signed in to change notification settings - Fork 572
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve Data Paths and Glitch tests #1963
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Show up to 8 VU meters. Display types being tested.
Remove some dead code.
I just wanted to get this uploaded so it can be tested. |
robertwu1
reviewed
Feb 16, 2024
robertwu1
reviewed
Feb 16, 2024
apps/OboeTester/app/src/main/java/com/mobileer/oboetester/TestDataPathsActivity.java
Outdated
Show resolved
Hide resolved
robertwu1
reviewed
Feb 16, 2024
apps/OboeTester/app/src/main/java/com/mobileer/oboetester/TestDataPathsActivity.java
Outdated
Show resolved
Hide resolved
robertwu1
reviewed
Feb 16, 2024
apps/OboeTester/app/src/main/java/com/mobileer/oboetester/BaseAutoGlitchActivity.java
Outdated
Show resolved
Hide resolved
Addressed comments.
robertwu1
reviewed
Feb 23, 2024
apps/OboeTester/app/src/main/java/com/mobileer/oboetester/TestDataPathsActivity.java
Outdated
Show resolved
Hide resolved
Use level for mask testing.
robertwu1
reviewed
Feb 26, 2024
apps/OboeTester/app/src/main/java/com/mobileer/oboetester/TestDataPathsActivity.java
Outdated
Show resolved
Hide resolved
robertwu1
reviewed
Feb 26, 2024
apps/OboeTester/app/src/main/java/com/mobileer/oboetester/TestDataPathsActivity.java
Show resolved
Hide resolved
I hope you are not helping my wife do all this to my phone cause it’s
sounding exactly to a tea I don’t know much about stuff like this but I do
know when my phone is cloned or whatever they do to spy on my phone but 2
years is plenty enough time to find out that I’m as loyal as it gets now
the other hand of tracking me n always knowing when I’m on the way home
isn’t cool I don’t know if that’s what you doin but if you are plz help me
out in get this stuff off my phone plz
null
…On Fri, Feb 16, 2024 at 11:59 AM Phil Burk ***@***.***> wrote:
Support Data Paths testing for USB and wired headsets.
Add channel selectors for Manual Glitch Activity so we can test individual
loopback paths.
Improve display of test results.
Prevent mismatching datapath devices such as mic and USB headphones.
This is WIP.
We still need to convert all the paths to the new style.
And we need more check boxes that reflect the test areas.
------------------------------
You can view, comment on, or merge this pull request online at:
#1963
Commit Summary
- d15051c
<d15051c>
OboeTester: improve Data Paths for wired headsets
- 3099abb
<3099abb>
more data paths improvement
- 8143831
<8143831>
Change checkboxes.
File Changes
(13 files <https://github.com/google/oboe/pull/1963/files>)
- *M* apps/OboeTester/app/src/main/cpp/analyzer/BaseSineAnalyzer.h
<https://github.com/google/oboe/pull/1963/files#diff-b220d28506ba7a440dc3e8e59dcab92ec6738054e8ce90e77653421f7142bcb1>
(3)
- *M* apps/OboeTester/app/src/main/cpp/analyzer/GlitchAnalyzer.h
<https://github.com/google/oboe/pull/1963/files#diff-0889584bf4d9de58992d0370d187108e689f5910fee131bc4df2969a49ffca63>
(8)
- *M* apps/OboeTester/app/src/main/cpp/jni-bridge.cpp
<https://github.com/google/oboe/pull/1963/files#diff-5b6fff67944b97bc294482f5b278202fb16e5f5ebf365b1f980676b2a6bc10e6>
(6)
- *M*
apps/OboeTester/app/src/main/java/com/mobileer/oboetester/AutomatedGlitchActivity.java
<https://github.com/google/oboe/pull/1963/files#diff-505c77d7dcbb853d2b065a3e7eafb41679dfb0bc7ecf1741def0b5bae798daef>
(2)
- *M*
apps/OboeTester/app/src/main/java/com/mobileer/oboetester/BaseAutoGlitchActivity.java
<https://github.com/google/oboe/pull/1963/files#diff-1c17d806220ea4e9cf75a330c77835b7cdb73540c1741bbe76b9feb541f24b68>
(138)
- *M*
apps/OboeTester/app/src/main/java/com/mobileer/oboetester/ManualGlitchActivity.java
<https://github.com/google/oboe/pull/1963/files#diff-295056d6834ca8fb3290bbf88023b8a5202b1620d950a816065f80ac69694102>
(71)
- *M*
apps/OboeTester/app/src/main/java/com/mobileer/oboetester/TestAudioActivity.java
<https://github.com/google/oboe/pull/1963/files#diff-5a8f57a924982914c7050e786656e6de5d128bb4621c3b3d9163bed82521f633>
(4)
- *M*
apps/OboeTester/app/src/main/java/com/mobileer/oboetester/TestDataPathsActivity.java
<https://github.com/google/oboe/pull/1963/files#diff-41ba868533cde4ffcc74b7f79ef517878843bb93e31c91e68816bda9fa3b5e9c>
(464)
- *M*
apps/OboeTester/app/src/main/java/com/mobileer/oboetester/TestInputActivity.java
<https://github.com/google/oboe/pull/1963/files#diff-5d11a78ca826fc7fb6ed05722dda1155878735d58ed3fe1eb0ac7088d6db89e0>
(7)
- *M* apps/OboeTester/app/src/main/res/layout/activity_data_paths.xml
<https://github.com/google/oboe/pull/1963/files#diff-ea31356f3a89b6e559ea49c81e3101a190923f4f3f32871dbbaad18415055b12>
(16)
- *M*
apps/OboeTester/app/src/main/res/layout/activity_manual_glitches.xml
<https://github.com/google/oboe/pull/1963/files#diff-db683f237535e23634166dc9e34780429609c3d18f2b6df5aead8159b9a232e2>
(1)
- *M* apps/OboeTester/app/src/main/res/layout/activity_test_input.xml
<https://github.com/google/oboe/pull/1963/files#diff-8f4b91bf0631daa0db9f16262cfb39372cdd6d518ba275299a88f5a81486df42>
(24)
- *M* apps/OboeTester/app/src/main/res/values/strings.xml
<https://github.com/google/oboe/pull/1963/files#diff-753f0e128969a7a9b330282b18a168315082aa4ceef62a0602a4a6d11f5a68b4>
(2)
Patch Links:
- https://github.com/google/oboe/pull/1963.patch
- https://github.com/google/oboe/pull/1963.diff
—
Reply to this email directly, view it on GitHub
<#1963>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/A5DGUASBX2T4M36Q3JKOXHTYT6NBZAVCNFSM6AAAAABDMNUTQ2VHI2DSMVQWIX3LMV43ASLTON2WKOZSGEZTSMJSGM4DCMY>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
@JONNIE32 - we are writing tests to detect audio pops and distortion caused by software problems in our phones. |
Someone is helping her I’m sorry I don’t know much about this stuff but I
can tell when my phone is messed with I went in paid 1300 bucks thinking it
would stop I know now how it’s done for the most post
null
…On Mon, Feb 26, 2024 at 6:55 PM Phil Burk ***@***.***> wrote:
@JONNIE32 <https://github.com/JONNIE32> - we are writing tests to detect
audio pops and distortion caused by software problems in our phones.
This has nothing to do with your phone.
—
Reply to this email directly, view it on GitHub
<#1963 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/A5DGUAWIGDZEG3TS5SVTVP3YVUVHVAVCNFSM6AAAAABDMNUTQ2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNRVGU4TSMRYGU>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Address some comments
robertwu1
approved these changes
Feb 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support Data Paths testing for USB and wired headsets.
Add channel selectors for Manual Glitch Activity so we can test individual loopback paths.
Improve display of test results.
Prevent mismatching datapath devices such as mic and USB headphones.