Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LiveEffect: Add foreground service #2070

Merged
merged 5 commits into from
Jul 12, 2024
Merged

LiveEffect: Add foreground service #2070

merged 5 commits into from
Jul 12, 2024

Conversation

robertwu1
Copy link
Collaborator

Fixes #2062

@robertwu1 robertwu1 requested a review from philburk July 11, 2024 21:38
@robertwu1 robertwu1 mentioned this pull request Jul 11, 2024
Closed
philburk
philburk reviewed Jul 11, 2024
View reviewed changes
Copy link
Collaborator

@philburk philburk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the service stop while it is in the background?
Can the audio keep running?

...veEffect/src/main/java/com/google/oboe/samples/liveEffect/DuplexStreamForegroundService.java Outdated Show resolved Hide resolved
...veEffect/src/main/java/com/google/oboe/samples/liveEffect/DuplexStreamForegroundService.java Show resolved Hide resolved
samples/LiveEffect/src/main/java/com/google/oboe/samples/liveEffect/MainActivity.java Outdated Show resolved Hide resolved
@robertwu1 robertwu1 merged commit 4f3ed88 into main Jul 12, 2024
3 checks passed
@robertwu1 robertwu1 deleted the robertwu/addforegroundservicetoliveeffect branch July 12, 2024 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philburk philburk philburk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Glitch in background, exclusive mode
2 participants
@robertwu1 @philburk