Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

opensles: scale buffer size by sample rate #762

Merged
merged 1 commit into from
Jan 25, 2020
Merged

opensles: scale buffer size by sample rate #762

merged 1 commit into from
Jan 25, 2020

Conversation

philburk
Copy link
Collaborator

@philburk philburk commented Jan 15, 2020

Use smaller buffer sizes for lower rates.
Base on 20 msec period common on Android.
Pass mSampleRate so caller can guarantee it is set.

Fixes #751

Use smaller buffer sizes for lower rates.
Base on 20 msec period common on Android.
Pass mSamplerate so caller can guarantee it is set.
Copy link
Collaborator

@android-usb android-usb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@philburk philburk merged commit 5b56aef into master Jan 25, 2020
@philburk philburk deleted the fixbufsize branch January 25, 2020 00:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants