Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a Y2038 bug by replacing Int32x32To64 with regular multiplication #690

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix a Y2038 bug by replacing Int32x32To64 with regular multiplication #690

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion omaha/base/time.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -300,7 +300,7 @@ time_t FileTimeToTimeT(const FILETIME& file_time) {
void TimeTToFileTime(const time_t& time, FILETIME* file_time) {
ASSERT1(file_time);

LONGLONG ll = Int32x32To64(time, kSecsTo100ns) + kTimeTConvValue;
LONGLONG ll = (static_cast<LONGLONG>(time) * kSecsTo100ns) + kTimeTConvValue;
file_time->dwLowDateTime = static_cast<DWORD>(ll);
file_time->dwHighDateTime = static_cast<DWORD>(ll >> 32);
}
Expand Down