Implement max length behavior #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4 +/- ##
==========================================
+ Coverage 86.87% 87.66% +0.79%
==========================================
Files 6 6
Lines 655 681 +26
==========================================
+ Hits 569 597 +28
+ Misses 86 84 -2
Continue to review full report at Codecov.
|
WilliamDenniss
force-pushed
the
max-digits
branch
4 times, most recently
from
f90ffae to
c4c7669
Compare
As documented in OLC issue number 190: 1. If you ask the library to encode a lat/long with more than 15 digits, the library will return a plus code with 15 digits. 2. If you ask the library to decode a plus code with more than 15 digits, the library will only take the first 15 digits into account with the returned code area. 3. Plus codes with more than 15 digits will be treated as valid if all the other validity constraints are satisfied. If the plus code has an invalid character after the 15th digit, it will be treated as invalid.
WilliamDenniss
force-pushed
the
max-digits
branch
from
c4c7669 to
6f8cb47
Compare
WilliamDenniss
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement behavior specified in google/open-location-code#190