Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mentions of Open Location Code and plus codes #650

Merged
merged 4 commits into from
Jan 9, 2025

Conversation

fulldecent
Copy link
Contributor

This updates mentions of "Open Location Codes" "Plus Codes" and other errors in this repo to instead properly refer to:

  1. Mention "Open Location Code" the project, library and API; and
  2. Mention "plus codes" referring to the generated codes.

This fixes issue #431.


This also fixes a reference to the old URL openlocationcode.com to instead go to its new URL, which I hope is in scope for these name changes.

@fulldecent fulldecent changed the title Fix mentions of OLC and PC, fixes #431 Fix mentions of Open Location Code and plus codes Dec 14, 2024
@drinckes
Copy link
Contributor

For future reference, this PR is on the big side. It's better to send multiple small PRs that can be reviewed/approved/merged quickly, rather than large ones.

@drinckes drinckes self-assigned this Dec 23, 2024
@fulldecent
Copy link
Contributor Author

Got it.

There's only five words in this PR, just many occurrences of those five words. Would you like me to split up this PR for some of the files separately?

@fulldecent fulldecent changed the title Fix mentions of Open Location Code and plus codes [WIP] Fix mentions of Open Location Code and plus codes Dec 23, 2024
@fulldecent
Copy link
Contributor Author

Todo:

  • Update "plus code" -> "Plus Code" because
    ## Plus Codes
    When referring to Plus Codes in English, the **only** term that should be used is "Plus Code", in Title Case.
    Some examples of usage are:
    * "My Plus Code is CX37+M9."
    * "I gave your Plus Code to the cab driver and he found the way without any problems."
    * "Will the postcard arrive if I put your Plus Code as the address?"
    * "Enter your Plus Code or street address here."

@drinckes
Copy link
Contributor

You've got a formatting failure in the Java source.

CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
Documentation/FAQ.md Outdated Show resolved Hide resolved
Documentation/Reference/plus.codes_Website_API.md Outdated Show resolved Hide resolved
Documentation/Specification/olc_definition.adoc Outdated Show resolved Hide resolved
js/README.md Show resolved Hide resolved
@fulldecent
Copy link
Contributor Author

Thanks for the review. This PR is rebased, removes formatting changes and standardizes on "Plus Codes" and "Open Location Code" as per specification at

## Plus Codes
When referring to Plus Codes in English, the **only** term that should be used is "Plus Code", in Title Case.
Some examples of usage are:
* "My Plus Code is CX37+M9."
* "I gave your Plus Code to the cab driver and he found the way without any problems."
* "Will the postcard arrive if I put your Plus Code as the address?"
* "Enter your Plus Code or street address here."

@fulldecent fulldecent changed the title [WIP] Fix mentions of Open Location Code and plus codes Fix mentions of Open Location Code and plus codes Jan 5, 2025
@drinckes
Copy link
Contributor

drinckes commented Jan 9, 2025

Thanks for helping to clean up the documentation!

@drinckes drinckes closed this Jan 9, 2025
@drinckes drinckes reopened this Jan 9, 2025
@drinckes
Copy link
Contributor

drinckes commented Jan 9, 2025

lol merge first then close

@drinckes drinckes merged commit 26fa64f into google:main Jan 9, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants