Add subtest_previous PhaseFailureCheckpoint #992
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
PhaseFailureCheckpoint
currently only supports two modes of failure checking:last
andall_previous
. As noted in the docstring for thePhaseFailureCheckpoint
, theall_previous
does not play well with subtests:To remedy this, this PR adds support for a
subtest_previous
mode which checks all phases in the same subtest as the checkpoint, or if the checkpoint is not in any subtest falls back to the behavior ofall_previous
.This allows one to use a checkpoint to short-circuit execution of a subtest, without quitting the overall test. A good example of this can be seen in the unittest
test_subtest_previous_fail_subtest__fail_in_subtest
. We construct a phasegroup as follows:Which results in the following execution:
This change is![Reviewable](https://camo.githubusercontent.com/1541c4039185914e83657d3683ec25920c672c6c5c7ab4240ee7bff601adec0b/68747470733a2f2f72657669657761626c652e696f2f7265766965775f627574746f6e2e737667)