Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dropped orders should not come with dropped reload stations in cvrp_r… #4519

Merged
merged 2 commits into from
Jan 27, 2025
Merged

Dropped orders should not come with dropped reload stations in cvrp_r… #4519

merged 2 commits into from
Jan 27, 2025

Conversation

arnabanimesh
Copy link
Contributor

…eload.py example output

@Mizux Mizux self-requested a review January 26, 2025 09:39
Mizux
Mizux approved these changes Jan 26, 2025
View reviewed changes
Copy link
Collaborator

@Mizux Mizux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM good catch !

@Mizux Mizux self-assigned this Jan 26, 2025
@Mizux Mizux added this to the v9.12 milestone Jan 26, 2025
@Mizux
Copy link
Collaborator

Mizux commented Jan 26, 2025

Will merge it on Monday, want to perform the same fix on the C++, Java and .Net samples if any...

@Mizux Mizux added Bug Solver: Routing Uses the Routing library and the original CP solver labels Jan 26, 2025
@arnabanimesh
Copy link
Contributor Author

Updated the Python notebook as well

@arnabanimesh arnabanimesh requested a review from Mizux January 26, 2025 22:39
@Mizux
Copy link
Collaborator

Mizux commented Jan 27, 2025

Updated the Python notebook as well
Thx for notebook update, please note usually we regenerate them just before a release using this script:
https://github.com/google/or-tools/blob/main/tools/generate_all_notebooks.sh

TODO(mizux): need to modify it to add your metadata update

@Mizux Mizux merged commit 3065641 into google:main Jan 27, 2025
23 of 146 checks passed
@arnabanimesh arnabanimesh deleted the patch-1 branch January 27, 2025 09:21
@Mizux
Copy link
Collaborator

Mizux commented Jan 27, 2025

Script fixed in 6eb0802

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mizux Mizux Awaiting requested review from Mizux

Assignees

@Mizux Mizux

Labels
Bug Solver: Routing Uses the Routing library and the original CP solver
Projects
None yet
Milestone
v9.12
Development

Successfully merging this pull request may close these issues.
2 participants
@arnabanimesh @Mizux