Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crosvm: Fix apt-get command #11780

Merged
merged 1 commit into from
Apr 5, 2024
Merged

crosvm: Fix apt-get command #11780

merged 1 commit into from
Apr 5, 2024

Conversation

maflcko
Copy link
Contributor

@maflcko maflcko commented Apr 4, 2024

Using apt upgrade without -y is problematic, because it may fail:

Step #17: Step 3/4 : RUN apt-get upgrade && apt-get install --yes --no-install-recommends     libclang-dev     pkg-config     libcap-dev
Step #17:  ---> Running in 4fd961f9329f
Step #17: Reading package lists...
Step #17: Building dependency tree...
Step #17: Reading state information...
Step #17: Calculating upgrade...
Step #17: The following packages will be upgraded:
Step #17:   bsdutils fdisk libblkid1 libfdisk1 libmount1 libsmartcols1 libuuid1 mount
Step #17:   util-linux
Step #17: 9 upgraded, 0 newly installed, 0 to remove and 0 not upgraded.
Step #17: Need to get 1901 kB of archives.
Step #17: After this operation, 4096 B of additional disk space will be used.
Step #17: Do you want to continue? [Y/n] Abort.
Step #17: The command '/bin/sh -c apt-get upgrade && apt-get install --yes --no-install-recommends     libclang-dev     pkg-config     libcap-dev' returned a non-zero code: 1
Finished Step #17
ERROR

Also, an apt-get update is needed, anyway.

Fix both issues by replacing upgrade with update.

Copy link

github-actions bot commented Apr 4, 2024

maflcko is a new contributor to projects/crosvm. The PR must be approved by known contributors before it can be merged. The past contributors are: denniskempin

@maflcko
Copy link
Contributor Author

maflcko commented Apr 4, 2024

cc @denniskempin

Copy link
Contributor

@denniskempin denniskempin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fix!

@jonathanmetzman jonathanmetzman merged commit d710f6f into google:master Apr 5, 2024
16 checks passed
@maflcko maflcko deleted the patch-1 branch April 5, 2024 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants