Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

typing_extensions: Fix "isinsance" typo #12554

Merged
merged 2 commits into from
Oct 7, 2024
Merged

typing_extensions: Fix "isinsance" typo #12554

merged 2 commits into from
Oct 7, 2024

Conversation

correctmost
Copy link
Contributor

Fixes this error during coverage builds:

 === Uncaught Python exception: ===
NameError: name 'isinsance' is not defined
Traceback (most recent call last):
  File "fuzz_typing_extensions.py", line 65, in TestOneInput
NameError: name 'isinsance' is not defined

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 2, 2024

correctmost is a new contributor to projects/typing_extensions. The PR must be approved by known contributors before it can be merged.

@vitorguidi
Copy link
Contributor

/gcbrun trial_build.py python

vitorguidi
vitorguidi approved these changes Oct 7, 2024
View reviewed changes
Copy link
Contributor

@vitorguidi vitorguidi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@vitorguidi vitorguidi merged commit 16f697c into google:master Oct 7, 2024
15 checks passed
@correctmost correctmost deleted the cm/typing-extensions-fix branch October 7, 2024 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vitorguidi vitorguidi vitorguidi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@correctmost @vitorguidi