-
Notifications
You must be signed in to change notification settings - Fork 2.5k
feat(abseil-cpp): Migrate abseil-cpp to Ubuntu 24.04 #14216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
hunsche is a new contributor to projects/abseil-cpp. The PR must be approved by known contributors before it can be merged. The past contributors are: derekmauro, junyer, DonggeLiu, PiotrSikora, inferno-chromium, kabeer27 |
192d7d5 to
c154200
Compare
|
/gcbrun trial_build.py abseil-cpp |
projects/abseil-cpp/WORKSPACE
Outdated
|
|
||
| install_deps() | ||
|
|
||
| http_archive( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we need this ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was an attempt to fix the existing errors in the project, but it didn't work. There are more errors. I'm going to revert this and migrate it exactly as it is.
|
/gcbrun trial_build.py abseil-cpp |
|
/gcbrun trial_build.py abseil-cpp |
Summary
This pull request migrates the
abseil-cppproject to use the newubuntu-24-04base image for fuzzing. This makes it one of the first pilot projects to be migrated to the new, modernized build environment.Motivation
As part of the broader OSS-Fuzz initiative to keep our build environments up-to-date, we are gradually migrating projects to newer base operating systems. This provides projects with access to more recent compilers, updated libraries (e.g., libc), and modern tooling, which can lead to better bug detection and overall fuzzer stability.
Changes in this PR
This migration involves three key changes:
projects/abseil-cpp/project.yaml: Sets thebase_os_versionproperty toubuntu-24-04, officially opting the project into the new base image.projects/abseil-cpp/Dockerfile: Updates theFROMinstruction to pull the correspondinggcr.io/oss-fuzz-base/base-builder:ubuntu-24-04image. This ensures the project's build environment aligns with the specified OS version.infra/ci/check_base_os.py: Enablesubuntu-24-04as aSUPPORTED_VERSIONin the CI presubmit script. This is a one-time change that allows this and future project migrations to pass validation.Verification
All CI checks, including the previously failing
trial-build, are expected to pass. The project has also been confirmed to build successfully with the new base image.