libjpeg-turbo: enable i386 architecture and improve fuzzer regarding msan #2680
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
lets wait on monday for @jonathanmetzman to take a look. |
LebedevRI
reviewed
Aug 12, 2019
| tjDecompress2( | ||
| jpegDecompressor, data, size, buf.get(), width, 0, height, TJPF_RGB, 0); | ||
|
|
||
| // For memory sanitizer, test each output byte |
There was a problem hiding this comment.
It is indeed bad that MSAN doesn't complain about this automatically (google/sanitizers#883)
That being said, you want __msan_check_mem_is_initialized().
jonathanmetzman
approved these changes
Aug 12, 2019
There was a problem hiding this comment.
I'm fine with the i386 changes.
I recommend making the MSAN change as @LebedevRI suggested
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.