Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a fixed Bazel version for Project-Oak #3131

Merged
merged 1 commit into from
Dec 17, 2019

Conversation

ipetr0v
Copy link
Contributor

@ipetr0v ipetr0v commented Dec 15, 2019

This change fixed Bazel version (1.1.0) used in Docker by Project-Oak.

Orginated from #3093 (comment)

@ipetr0v
Copy link
Contributor Author

ipetr0v commented Dec 15, 2019

cc @tiziano88

@tiziano88
Copy link
Member

Could you mention #3093 (comment) the commit message, since that's where the requirement is from.

@ipetr0v
Copy link
Contributor Author

ipetr0v commented Dec 15, 2019

Looks like #3093 make this build fail in Travis.

@ipetr0v ipetr0v force-pushed the oak_fix_bazel_version branch from adf4818 to a3d990d Compare December 15, 2019 17:21
@Dor1s
Copy link
Contributor

Dor1s commented Dec 16, 2019

The same error seems to still persist:

ERROR: /root/.cache/bazel/_bazel_root/872aac72dffae06b4e2a5b0308508d03/external/com_google_absl/absl/strings/BUILD.bazel:30:1: undeclared inclusion(s) in rule '@com_google_absl//absl/strings:strings':
this rule is missing dependency declarations for the following files included by 'external/com_google_absl/absl/strings/str_replace.cc':
  '/usr/local/lib/clang/10.0.0/share/asan_blacklist.txt'

Do you want to land this anyway?

@tiziano88
Copy link
Member

Yes please, this is not a fix for that issue, but something we should do anyways.

Thanks

@Dor1s Dor1s merged commit ff3f53a into google:master Dec 17, 2019
@ipetr0v ipetr0v deleted the oak_fix_bazel_version branch December 17, 2019 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants