Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow specifying experimental sanitizers. #432

Merged
merged 4 commits into from
Mar 7, 2017

Conversation

oliverchang
Copy link
Collaborator

See #378.

@inferno-chromium
Copy link
Collaborator

LGTM

@mikea
Copy link
Contributor

mikea commented Mar 3, 2017

Not sure why would you want to do this. Why not simply comments in project.yaml?

sanitizers:
  - undefined # experimental

@oliverchang
Copy link
Collaborator Author

it's much easier to parse. I don't think yaml parser preserves comments?

@oliverchang
Copy link
Collaborator Author

oliverchang commented Mar 3, 2017

please take another look. Changed to support:

sanitizers:
  - address
  - undefined:
      experimental: true

In addition to what we already support (list of sanitizer strings)

@oliverchang
Copy link
Collaborator Author

Thanks. Will merge this next week, since Mike is testing builder changes.

@oliverchang oliverchang merged commit 21851f0 into google:master Mar 7, 2017
@oliverchang oliverchang deleted the experimental branch March 7, 2017 17:53
tmatth pushed a commit to tmatth/oss-fuzz that referenced this pull request Oct 22, 2018
DavidKorczynski pushed a commit that referenced this pull request Jul 9, 2024
Search for file in git commit tree at the particular commit, instead of
at tip of tree trunk.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants