[Loki] Initial integration #4777
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@cyriltovena This is just a friendly ping to let you know that to complete this integration at least one maintainers email address is needed for the project.yaml file in the PR. Feel free to leave any email address in the a comment in this thread and I will make sure to get it added. |
AdamKorcz
changed the title
|
@jonathanmetzman @inferno-chromium Ready for review |
inferno-chromium
approved these changes
Dec 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds initial integration of Loki.
We are currently waiting for the fuzzer to be merged upstream here: grafana/loki#3031
For Loki maintainers: The files in this PR allow the fuzzers in the PR above to be run continuously. All that is needed on this side is at least one maintainers email address in the project.yaml file. You can add it per your convenience or you can leave your email address in this thread and I will make sure to add it. The list can be changed at any time by making a pull request with the desired changes. If you have any questions about this integration, feel free to drop them in this PR or in the PR on the Loki side. Please note that I have added my own email address on the mailing list to see the integration through to completion. This does mean that all bugs and vulnerabilities will be visible by me as all email addresses on that list will have access to these. If you prefer me off the list, just let me know, and I will remove myself.