Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zip-rs: initial integration #5400

Merged
merged 6 commits into from
Jan 25, 2022
Merged

Conversation

DavidKorczynski
Copy link
Collaborator

@DavidKorczynski DavidKorczynski commented Mar 15, 2021

zip-rs is a rust library which supports reading and writing of simple ZIP files.

Data on crates.io shows it has been downloaded 5.7 million times https://crates.io/crates/zip and has 344 reverse dependencies https://crates.io/crates/zip/reverse_dependencies which also shows its list of customers


@Plecra would you be interested in integrating zip-rs into oss-fuzz? By way of OSS-Fuzz we can add fuzzers to zip-rs and run them continuously - you will then receive reports whenever crashes are found. If you would like to integrate, could you please provide a set of email(s) that will get access to the data produced by OSS-Fuzz, such as bug reports. The emails should be linked to a Google account in order to view the detailed reports and notice the emails affiliated with the project will be public in the OSS-Fuzz repo, as they will be part of a configuration file. We can also add the fuzzers of this PR to the main zip-rs repository.

@DavidKorczynski DavidKorczynski changed the title initial integration of zip-rs. zip-rs: initial integration Mar 15, 2021
@Plecra
Copy link

Plecra commented Mar 16, 2021

Wow, thankyou! I think this could do zip a lot of good.

Could you help me understand what would be involved in generating inputs for a crate like zip? I imagine it's more involved than completely random files that the parser would just treat as junk 😄

My own email (attached to this github account) would be best at the moment.

@DavidKorczynski
Copy link
Collaborator Author

DavidKorczynski commented Apr 1, 2021

Wow, thankyou! I think this could do zip a lot of good.

Could you help me understand what would be involved in generating inputs for a crate like zip? I imagine it's more involved than completely random files that the parser would just treat as junk

My own email (attached to this github account) would be best at the moment.

The benefit at first would be to test parser and ensure no unknown panics are being thrown. We could also add a fuzzer that checks if decompress(compress(s)) == s holds true, i.e. look for divergences.

Would you be happy to have the fuzzers in the upstream repository? If so, I can do a PR on zip-rs and move it all up there before merging in this PR.

@zamazan4ik
Copy link

@DavidKorczynski do you have any updates on this PR? I am interested in it a lot :)

@DavidKorczynski
Copy link
Collaborator Author

Thanks @zamazan4ik - I will make this one ready today

@zamazan4ik
Copy link

@DavidKorczynski just a friendly reminder :)

@DavidKorczynski DavidKorczynski marked this pull request as ready for review January 24, 2022 18:23
@zamazan4ik
Copy link

@DavidKorczynski do we need to ping someone explicitly for the review?

@DavidKorczynski
Copy link
Collaborator Author

@inferno-chromium @jonathanmetzman @oliverchang this one is ready for reaview

@inferno-chromium inferno-chromium merged commit 3403ecc into google:master Jan 25, 2022
DonggeLiu pushed a commit that referenced this pull request Feb 3, 2022
* initial integration of zip-rs.

* update contact

* Updated Dockerfile

* Update licenses to 2022;

* updated comments in Cargo file
MartinPetkov pushed a commit to MartinPetkov/oss-fuzz that referenced this pull request Aug 15, 2022
* initial integration of zip-rs.

* update contact

* Updated Dockerfile

* Update licenses to 2022;

* updated comments in Cargo file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants