[infra] .options support for run command #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliverchang
reviewed
Oct 31, 2016
|
|
||
| # Use .options file if any. | ||
| fuzzer_name = run_args[0] | ||
| options_file = fuzzer_name + ".options" |
There was a problem hiding this comment.
should this be checking for .options in /out, since the fuzzer binary can be invoked without it's full path name?
Initial work for #19.
|
@oliverchang, how about this version? It is even shorter than python and will work both for script and for container. A bit hacky but I don't see why it won't suit us for a very long time. |
mikea
force-pushed
the
run_use_options
branch
from
7170b14 to
3f7ead2
Compare
|
Nice, LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial work for #19.
I'm not happy that I pull
python3package in. I'd like to add this functionality to libfuzzer-runner, but I am not sure I'd like to add python dependency to that image as well. Ideas are appreciated.