-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix OpenSK build problem (nightly version) #7177
Fix OpenSK build problem (nightly version) #7177
Conversation
Note that this bug was already (almost) fixed in #6648, but a recently introduced newer nightly started to be incompatible. |
@catenacyber Can you double check if this is sound, or was there a specific reason you omitted the nightly version in your PR? |
CI seems unhappy... There may be a workaround I do not think of right now... You can try to reproduce locally the check_build failure to investigate |
You should also invetigate why rustc sees |
Ah right thanks, I had something in the back of my mind, but it worked locally. I think I found a compiler version that is both
Deprecations like with Are we the only Rust project that pins compiler version? Is there another workaround for the inevitable next breakage? |
I think so
None that I know of, just update code and dependencies to work with the latest nightly... |
* exports a more specific nightly version * trying intermediate compiler version to compromise
* exports a more specific nightly version * trying intermediate compiler version to compromise
The bug occured first in our GitHub workflow, and was then automatically reported. OpenSK pins the nightly for its builds, and that is necessary for the build script here as well.