Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python-multipart: initial integration #8398

Closed
wants to merge 3 commits into from
Closed

python-multipart: initial integration #8398

wants to merge 3 commits into from

Conversation

manunio
Copy link
Contributor

@manunio manunio commented Sep 2, 2022

Hi, python-multipart is a streaming multipart parser for Python.
It has 2 million+ monthly downloads as per pypistats, and is being used by projects like fastapi, starlette.

@manunio
Copy link
Contributor Author

manunio commented Sep 8, 2022

Hi @jonathanmetzman please review this pr.

@manunio
Copy link
Contributor Author

manunio commented Sep 12, 2022

Hi @Navidem please review this pr :)

@jonathanmetzman
Copy link
Contributor

Has upstream agreed to this?

@manunio
Copy link
Contributor Author

manunio commented Sep 18, 2022

Has upstream agreed to this?

@jonathanmetzman There's no response yet.

@jonathanmetzman
Copy link
Contributor

Has upstream agreed to this?

@jonathanmetzman There's no response yet.

We don't accept projects unless upstream agrees

@manunio
Copy link
Contributor Author

manunio commented Sep 18, 2022

Has upstream agreed to this?

@jonathanmetzman There's no response yet.

We don't accept projects unless upstream agrees

@jonathanmetzman thanks for the review, can you please clear doubt of mine. I can see pr #8347 with no response being merged. Whats the difference here? Just curious thanks.

@jonathanmetzman
Copy link
Contributor

Has upstream agreed to this?

@jonathanmetzman There's no response yet.

We don't accept projects unless upstream agrees

@jonathanmetzman thanks for the review, can you please clear doubt of mine. I can see pr #8347 with no response being merged. Whats the difference here? Just curious thanks.

These are our contractors and we treat these projects differently.

@manunio
Copy link
Contributor Author

manunio commented Sep 18, 2022

These are our contractors and we treat these projects differently.

@jonathanmetzman a previous pr: #8279 of mine was merged same way, that's why it was creating confusion for me.

@jonathanmetzman
Copy link
Contributor

I probably shouldn't have merged it because there's no one upstream to accept bug reports, but there's a linked issue where upstream agreed to the integration. Here there is nothing

@manunio
Copy link
Contributor Author

manunio commented Sep 18, 2022

I probably shouldn't have merged it because there's no one upstream to accept bug reports, but there's a linked issue where upstream agreed to the integration. Here there is nothing

Yes, that was because maintainer agreed a day or two later. and thanks for clearing my doubts I'll keep this in mind for my contributions :)

@jonathanmetzman
Copy link
Contributor

I probably shouldn't have merged it because there's no one upstream to accept bug reports, but there's a linked issue where upstream agreed to the integration. Here there is nothing

Yes, that was because maintainer agreed a day or two later. and thanks for clearing my doubts I'll keep this in mind for my contributions :)

Yeah youre right, their agreement was later. I shouldn't have merged it but it ended up being OK.

@manunio manunio marked this pull request as draft September 21, 2022 16:39
@manunio manunio closed this Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants