Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

encoding_rs: initial integration #8652

Closed
wants to merge 11 commits into from
Closed

encoding_rs: initial integration #8652

wants to merge 11 commits into from

Conversation

manunio
Copy link
Contributor

@manunio manunio commented Oct 1, 2022

Hi, encoding_rs an implementation of the (non-JavaScript parts of) the Encoding Standard written in Rust.

@hsivonen
Copy link

hsivonen commented Oct 4, 2022

fuzz_labels is extremely unlikely to find anything at this point and isn't a good use of resources to run.

While the other two might find something, and if they did, that would be very notable and useful, my expectation level of fuzzing finding something at this point is low enough that I feel bad about using resources for continuous fuzzing of encoding_rs.

I don't object to integration, though, if Google considers this a good use of the resources of OSS-Fuzz regardless.

@manunio
Copy link
Contributor Author

manunio commented Oct 4, 2022

fuzz_labels is extremely unlikely to find anything at this point and isn't a good use of resources to run.

Hi thanks for your response, I have removed fuzz_labels.

While the other two might find something, and if they did, that would be very notable and useful, my expectation level of fuzzing finding something at this point is low enough that I feel bad about using resources for continuous fuzzing of encoding_rs.

I don't object to integration, though, if Google considers this a good use of the resources of OSS-Fuzz regardless.

Given the scale of this project's usage, I think using resources for this project would be worth it, but will have to wait for panel's decision.

@jonathanmetzman received permission from maintainer, please review this pr.

@manunio manunio marked this pull request as ready for review October 4, 2022 10:00
@jonathanmetzman
Copy link
Contributor

@jonathanmetzman received permission from maintainer, please review this pr.

Let me ask our team what we think about this since this is pretty unenthusiastic :-)

@manunio
Copy link
Contributor Author

manunio commented Oct 13, 2022

@jonathanmetzman received permission from maintainer, please review this pr.

Let me ask our team what we think about this since this is pretty unenthusiastic :-)

Hi @jonathanmetzman any updates ?

@hsivonen
Copy link

One more thing: --features simd-accel is more complex and, therefore, more likely to have bugs than the non-SIMD config. Therefore, if encoding_rs is fuzzed, fuzzing it with SIMD enabled is likely to be more valuable.

@manunio
Copy link
Contributor Author

manunio commented Nov 9, 2022

@jonathanmetzman Friendly ping :)

@manunio
Copy link
Contributor Author

manunio commented Dec 2, 2022

Hi, @Navidem can you please tell us panel's decision for this project.

@manunio
Copy link
Contributor Author

manunio commented Dec 22, 2022

@jonathanmetzman ping :)

@manunio
Copy link
Contributor Author

manunio commented Jan 23, 2023

@jonathanmetzman ping :)

@jonathanmetzman
Copy link
Contributor

@jonathanmetzman ping :)

I've asked the team about fuzzing this. I personally do not support it but if others do I will merge.

@manunio
Copy link
Contributor Author

manunio commented Jan 23, 2023

@jonathanmetzman ping :)

I've asked the team about fuzzing this. I personally do not support it but if others do I will merge.

okay thanks :)

@DonggeLiu
Copy link
Contributor

Our team find ClusterFuzzLite more suitable for this integration, would you please consider that instead? Thanks!
I will close this for mow : )

@DonggeLiu DonggeLiu closed this Feb 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants