Install Python3 explicitly #9507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The issue in #8915 is that the environment no longer has a leftover `python3` binary in `/bin/python3`. This uncovers a bug in the `upb` and `jwt-verify-lib` Dockerfiles where `python2` was installed (or no Python was installed). The issue seems to show up on Bazel projects only due to the way Bazel executes commands: it uses `env -` to run them in a clear environment, meaning that even `$PATH` is altered. Before bc02fd0 the issues in the Dockerfiles were hidden by the fact that the environment contained multiple versions of Python and one happened to be matched by this search path. This fixes #8915, reverting #8914 and #8909 tweaks to #8915. I did not do a similar thing for #8930 as maybe that can be fixed by changing the base python image? Tested: Tested that I can build the `upb` fuzzers with this change. Signed-off-by: Mihai Maruseac <mihaimaruseac@google.com>
|
Interesting. We build python3 from scratch. Maybe i'll just add a link in /bin instead of merging this. |
|
Oh, sure, that also works |
eamonnmcmanus
pushed a commit
to eamonnmcmanus/oss-fuzz
that referenced
this pull request
Mar 15, 2023
The issue in google#8915 is that the environment no longer has a leftover `python3` binary in `/bin/python3`. This uncovers a bug in the `upb` and `jwt-verify-lib` Dockerfiles where `python2` was installed (or no Python was installed). The issue seems to show up on Bazel projects only due to the way Bazel executes commands: it uses `env -` to run them in a clear environment, meaning that even `$PATH` is altered. Before bc02fd0 the issues in the Dockerfiles were hidden by the fact that the environment contained multiple versions of Python and one happened to be matched by this search path. This fixes google#8915, reverting google#8914 and google#8909 tweaks to google#8915. I did not do a similar thing for google#8930 as maybe that can be fixed by changing the base python image? Tested: Tested that I can build the `upb` fuzzers with this change. Signed-off-by: Mihai Maruseac <mihaimaruseac@google.com> Signed-off-by: Mihai Maruseac <mihaimaruseac@google.com>
asedeno
added a commit
to asedeno/oss-fuzz
that referenced
this pull request
Sep 23, 2024
Similar to google#9507, to get past failures of the form: ``` /usr/bin/env: 'python3': No such file or directory ``` Signed-off-by: Alejandro R. Sedeño <asedeno@google.com>
DavidKorczynski
pushed a commit
that referenced
this pull request
Sep 23, 2024
Similar to #9507, to get past failures of the form: ``` /usr/bin/env: 'python3': No such file or directory ``` Signed-off-by: Alejandro R. Sedeño <asedeno@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue in #8915 is that the environment no longer has a leftover
python3binary in/bin/python3. This uncovers a bug in theupbandjwt-verify-libDockerfiles wherepython2was installed (or no Python was installed).The issue seems to show up on Bazel projects only due to the way Bazel executes commands: it uses
env -to run them in a clear environment, meaning that even$PATHis altered. Before bc02fd0 the issues in the Dockerfiles were hidden by the fact that the environment contained multiple versions of Python and one happened to be matched by this search path.This fixes #8915, reverting #8914 and #8909 tweaks to #8915. I did not do a similar thing for #8930 as maybe that can be fixed by changing the base python image?
Tested: Tested that I can build the
upbfuzzers with this change.Signed-off-by: Mihai Maruseac mihaimaruseac@google.com