feat: Add ReadAt function for fileNode to allow gobinary extractor to successfully extract. #371
Conversation
| @@ -67,6 +67,20 @@ func (f *fileNode) Read(b []byte) (n int, err error) { | |||
| return f.file.Read(b) | |||
| } | |||
|
|
|||
| // Read reads the real file referred to by the fileNode. | |||
There was a problem hiding this comment.
Comment should start with "ReadAt".
You think we could refactor the Read method? Wondering if Read(b) is equivalent to ReadAt(b, 0).
There was a problem hiding this comment.
It's not quite the same, ReadAt will return io.EOF error if the buffer is bigger than what is there to read, but Read won't do that unless you do a second Read at the end of the file.
| @@ -67,6 +67,20 @@ func (f *fileNode) Read(b []byte) (n int, err error) { | |||
| return f.file.Read(b) | |||
| } | |||
|
|
|||
| // Read reads the real file referred to by the fileNode. | |||
| func (f *fileNode) ReadAt(b []byte, off int64) (n int, err error) { | |||
There was a problem hiding this comment.
Oh, it might also be a good idea to add a few tests? Probably doesn't many given the Read method is sufficiently tested.
There was a problem hiding this comment.
Good idea, added the tests! We might want to switch the wantErr in other tests to use the cmp library, since that also fails when wantErr is true but no error is returned.
There was a problem hiding this comment.
Yeah.... I'll create a bug to remind myself of changing wantErr from other tests. Thanks for the note and the added tests!
… successfully extract.
another-rex
force-pushed
the
filenode-readat
branch
from
477772e to
e8bc5e8
Compare
| @@ -67,6 +67,20 @@ func (f *fileNode) Read(b []byte) (n int, err error) { | |||
| return f.file.Read(b) | |||
| } | |||
|
|
|||
| // Read reads the real file referred to by the fileNode. | |||
| func (f *fileNode) ReadAt(b []byte, off int64) (n int, err error) { | |||
There was a problem hiding this comment.
Yeah.... I'll create a bug to remind myself of changing wantErr from other tests. Thanks for the note and the added tests!
The gobinary extractor expects a ReaderAt, but fileNode does not implement it. The underlying file does though, so this just exposes it.