Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add original manifest to Maven ManifestPatch #1134

Merged
merged 1 commit into from
Jul 24, 2024

Conversation

michaelkedar
Copy link
Member

Copying the EcosystemSpecific data from the Manifest to the ManifestPatch is a bit cumbersome for the override strategy, and ManifestPatch already has a field for the original manifest.

I don't think the current Maven EcosystemSpecific data is ever going to differ from the what's in the original manifest?

@michaelkedar michaelkedar requested a review from cuixq July 23, 2024 00:45
@codecov-commenter
Copy link

codecov-commenter commented Jul 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.21%. Comparing base (d9eccf2) to head (03f9a9e).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1134      +/-   ##
==========================================
- Coverage   65.24%   65.21%   -0.03%     
==========================================
  Files         162      162              
  Lines       13424    13424              
==========================================
- Hits         8758     8755       -3     
- Misses       4183     4185       +2     
- Partials      483      484       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@michaelkedar michaelkedar merged commit 2e60dcc into google:main Jul 24, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants