Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update Go to version 1.22.7 #1233

Merged
merged 5 commits into from
Sep 10, 2024
Merged

chore: update Go to version 1.22.7 #1233

merged 5 commits into from
Sep 10, 2024

Conversation

cuixq
Copy link
Contributor

@cuixq cuixq commented Sep 9, 2024

A few Go vulnerabilities are reported so this PR updates Go to the fixed version 1.22.7.

Also golang.org/x/mod@v0.21.0 requires Go 1.22.0 as mentioned in #1204.

Due to this version update, there are two new lint checks: copyloopvar and intrange.

@codecov-commenter
Copy link

codecov-commenter commented Sep 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.78%. Comparing base (0cd2051) to head (8669c5b).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1233   +/-   ##
=======================================
  Coverage   67.78%   67.78%           
=======================================
  Files         174      174           
  Lines       16759    16756    -3     
=======================================
- Hits        11360    11358    -2     
+ Misses       4770     4769    -1     
  Partials      629      629           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cuixq cuixq marked this pull request as ready for review September 9, 2024 05:43
@cuixq
Copy link
Contributor Author

cuixq commented Sep 9, 2024

@another-rex could you take another look on this? There are changes due to new lint rules...

Copy link
Contributor

@hogo6002 hogo6002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Xueqin!

Copy link
Collaborator

@another-rex another-rex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have so many test files haha, thanks for updating them! LGTM.

@cuixq cuixq merged commit 07619c0 into google:main Sep 10, 2024
13 checks passed
@cuixq cuixq deleted the update branch September 10, 2024 00:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants