Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(maven): remove the test of transitive scanning on native data source #1425

Merged
merged 3 commits into from
Dec 6, 2024

Conversation

cuixq
Copy link
Contributor

@cuixq cuixq commented Dec 6, 2024

This test makes a lot of unnecessary not found requests on repository.apache.org. This PR removes the test until we fix it.

@cuixq cuixq changed the title test(maven): remove the test of transitive scanning on data source test(maven): remove the test of transitive scanning on native data source Dec 6, 2024
@codecov-commenter
Copy link

codecov-commenter commented Dec 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.08%. Comparing base (5ae7169) to head (58d10f4).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1425      +/-   ##
==========================================
- Coverage   69.52%   69.08%   -0.45%     
==========================================
  Files         186      186              
  Lines       18326    18326              
==========================================
- Hits        12742    12661      -81     
- Misses       4909     4998      +89     
+ Partials      675      667       -8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cuixq cuixq requested a review from another-rex December 6, 2024 04:01
@cuixq cuixq marked this pull request as ready for review December 6, 2024 04:01
@cuixq cuixq requested a review from michaelkedar December 6, 2024 04:03
@another-rex another-rex merged commit 152731f into main Dec 6, 2024
14 checks passed
@another-rex another-rex deleted the cuixq-patch-2 branch December 6, 2024 04:09
Copy link
Member

@michaelkedar michaelkedar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see this pom using the repository.apache.org repo.

I think it's also in this pom. I'm pretty sure the test that uses it uses a local universe, but we might want to remove/change the url from the pom anyway

@cuixq
Copy link
Contributor Author

cuixq commented Dec 6, 2024

I think this may be one of the reasons slowing down the resolution on the mentioned POM. I like the idea to remove the URL, at least before we understand the full picture here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants