feat(maven): improve PreFetch for Maven #1485
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We disabled
PreFetch
in #1466 and this caused the resolution performance worse for deps.dev client.To enable
PreFetch
, we need to avoid unnecessary requests ofmaven-metadata.xml
files which is a result of callingMatchingVersions
andVersions
.This PR improves the logic in
PreFetch
so thatMatchingVersions
is only called for non-soft Maven requirements andVersions
is called for ecosystems other than Maven.It used to take about 1m to resove pom.xml without
PreFetch
enabled and now it takes less than 20 seconds.