Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: rewrite comments to be prefixed with the subject name #1579

Merged
merged 1 commit into from
Feb 10, 2025

Conversation

G-Rath
Copy link
Collaborator

@G-Rath G-Rath commented Feb 6, 2025

This addresses most of the violations reported by Golang - the remaining ones are most todo comments.

Not all of these are perfect, but I think most of them are a slight improvement; there are a few that also made me think the "thing" in question might want revisiting, such as IsAcceptenceTest which should probably actually be named something like IsAcceptenceTesting.

Copy link
Contributor

@cuixq cuixq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Copy link
Contributor

@hogo6002 hogo6002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@another-rex
Copy link
Collaborator

Hmm it looks like the container image is not consistent every build, I'll fix it in another PR.

@G-Rath
Copy link
Collaborator Author

G-Rath commented Feb 9, 2025

@another-rex I think it's just that another vulnerability has come out - I've opened #1592 to update the snapshots again

@codecov-commenter
Copy link

codecov-commenter commented Feb 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.30%. Comparing base (5f2f735) to head (f428a60).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1579      +/-   ##
==========================================
- Coverage   69.31%   69.30%   -0.02%     
==========================================
  Files         200      200              
  Lines       19033    19033              
==========================================
- Hits        13193    13190       -3     
- Misses       5133     5135       +2     
- Partials      707      708       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@another-rex another-rex merged commit 03b6994 into google:main Feb 10, 2025
13 checks passed
@another-rex another-rex deleted the update-comments branch February 10, 2025 01:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants