-
Notifications
You must be signed in to change notification settings - Fork 381
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: rewrite comments to be prefixed with the subject name #1579
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
e910095
to
b851d3c
Compare
Hmm it looks like the container image is not consistent every build, I'll fix it in another PR. |
@another-rex I think it's just that another vulnerability has come out - I've opened #1592 to update the snapshots again |
b851d3c
to
fa7b026
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1579 +/- ##
==========================================
- Coverage 69.31% 69.30% -0.02%
==========================================
Files 200 200
Lines 19033 19033
==========================================
- Hits 13193 13190 -3
- Misses 5133 5135 +2
- Partials 707 708 +1 ☔ View full report in Codecov by Sentry. |
fa7b026
to
f428a60
Compare
This addresses most of the violations reported by Golang - the remaining ones are most todo comments.
Not all of these are perfect, but I think most of them are a slight improvement; there are a few that also made me think the "thing" in question might want revisiting, such as
IsAcceptenceTest
which should probably actually be named something likeIsAcceptenceTesting
.