feat(staging): use GCS/new entities for API #3776
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelkedar
requested review from
another-rex,
cuixq,
hogo6002,
jess-lowe and
oliverchang
another-rex
reviewed
Aug 13, 2025
Contributor
another-rex
left a comment
another-rex
left a comment
There was a problem hiding this comment.
Looks pretty good to me
gcp/api/server_new.py
Outdated
|
|
||
| import osv | ||
|
|
||
| CURSOR_LAST_ID = 'last_id' |
Contributor
There was a problem hiding this comment.
Hmm can this be done at the metadata's type level? I.e. make metadata a struct with specific fields, and parse it into those fields, rather than having a dict that anyone can fill with anything. This way we can also limit the length of the ID to something reasonable as well.
Member
Author
There was a problem hiding this comment.
I've turned metadata into a dataclass, and made it raise the invalid page token error for unknown keys.
I didn't feel like doing the length check, since it isn't passed directly to datastore anyway.
another-rex
approved these changes
Aug 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying out the new GCS-backed vulnerabilities for making API queries on the staging instance (only). This should give us a good idea on the performance improvements.
server_new.pyto (temporarily) keep the new matching logic a bit separate