refactor: ecosystem helpers #3892
Conversation
| 'Ubuntu': Ubuntu, | ||
| 'Wolfi': APK, | ||
|
|
||
| # Ecosystems known in the schema, but without implementations. |
There was a problem hiding this comment.
Hmm... is there a test we can add here that reads the ecosystems.json in the osv-schema repo and checks it against this.?
There was a problem hiding this comment.
I remember bringing this up a while ago - #2615 (comment)
Not sure if you agree/disagree with Andrew's reasoning here. With renovate automatically updating the osv-schema it probably would always fail the tests.
There was a problem hiding this comment.
That should be fine though, with the recent ecosystems, they made both PRs (osv-schema and osv.dev _ecosystem.py) simultaneously. So we just need to merge the ecosystems.py PR before updating the schema to the newest version and it should work right?
There was a problem hiding this comment.
We currently have a test that checks that all the ecosystems in _ecosystems.py are valid ecosystems in the schema. Adding the vice versa test (that all schema ecosystems are in _ecosystems.py) would mean we'd always have to update both at the same time.
There was a problem hiding this comment.
Ah I see..., let's leave it as it is then.
| self.assertEqual('1.20.0', ecosystem.next_version('a4', '1.18.0')) | ||
| with self.assertRaises(ecosystems.EnumerateError): | ||
| ecosystem.next_version('doesnotexist123456', '1') | ||
| with warnings.catch_warnings(): |
There was a problem hiding this comment.
did not know warnings was a thing, wow.
michaelkedar
dismissed stale reviews from jess-lowe, cuixq, and another-rex
via
7cba064
4 participants
Closes #3745
OrderedEcosystem(for ones that implement sort_key only) andEnumerableEcosystem(which has enumerate versions)Ecosystemclassnext_version(but marked it as deprecated) since only malicious packages uses it to convert some ghsa records.OrderingUnsupportedEcosystemsince it's no longer particularly useful.I also updated the copyright year on all the ecoystems py files :)
I think this also incidentally closes #3063, since
supports_comparingis no longer used (it will be superseded by #3850 anyway).