Skip to content

Conversation

@mbauman
Copy link
Contributor

@mbauman mbauman commented Oct 8, 2025

No description provided.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @mbauman, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces support for the Julia programming language ecosystem, treating its versioning scheme as Semantic Versioning. The change is minimal, adding 'Julia' to the ecosystem mapping in osv/ecosystems/_ecosystems.py.

Highlights

  • Intent: This pull request aims to integrate Julia as a recognized ecosystem that adheres to Semantic Versioning (Semver) within the system.
  • Changes Summary: The primary change involves modifying osv/ecosystems/_ecosystems.py to add 'Julia' to the list of supported ecosystems, associating it with the SemverEcosystem class. This enables the system to correctly parse and handle Julia package versions according to Semver rules.
  • Reviewer Activity Summary:
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds support for the Julia ecosystem. The change is correct, but incomplete. I've added a comment with a suggestion to make the support for Julia more complete. Please review it.

@another-rex
Copy link
Contributor

Thanks for the PR! Please ignore gemini-bot's review there, we'll probably make it manually invoked from now on.

I do not believe we need to extend purl_helpers.py; we are generating our OSV records with purls attached, and the proposed purl spec requires the package UUID. It would be possible to look that up in purl_helpers.py through an HTTP GET to a JSON file, but that would represent a new thing that no other ecosystem does.

I think we still need it for parsing the purls though, as to do queries we convert the purls to ecosystem/name/version.
It should be relatively simple, we do not actually need the UUID logic if you provide the purls in the records themselves. So just adding

    'Julia':
        EcosystemPURL('julia', None),

to the list should be enough.

Signed-off-by: Matt Bauman <mbauman@juliahub.com>
@another-rex
Copy link
Contributor

/gcbrun

Copy link
Contributor

@another-rex another-rex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add some tests to the test_parse_purl section, since that is what the purl helper definition is will be mostly used for. You can put the uuid purls there to check that they are still parsed correctly.

mbauman and others added 2 commits October 10, 2025 11:38
Co-authored-by: Rex P <106129829+another-rex@users.noreply.github.com>
@mbauman
Copy link
Contributor Author

mbauman commented Oct 10, 2025

Great, added!

@another-rex
Copy link
Contributor

/gcbrun

@another-rex
Copy link
Contributor

Just need to run yapf -i purl_helpers_test.py, otherwise LGTM :)

@another-rex
Copy link
Contributor

/gcbrun

@another-rex
Copy link
Contributor

Test error should be fixed when we update our osv-schema submodule, no action required from your side :).

@another-rex
Copy link
Contributor

another-rex commented Oct 17, 2025

Can you press the merge from main button? The tests should be passing after that. (Also, you can tick a box to give maintainers permission to push to the PR branch, and we can do the updating directly.)

@mbauman
Copy link
Contributor Author

mbauman commented Oct 17, 2025

Yeah, I usually do check that box, but I think because this one came from a fork on our company org, we have that option turned off. I can't check it here. You are absolutely welcome to squash/cherry-pick/merge my work onto a branch of yours if that makes it any easier.

@another-rex
Copy link
Contributor

/gcbrun

@another-rex another-rex merged commit d17057b into google:master Oct 23, 2025
17 checks passed
@mbauman mbauman deleted the jlsec branch November 10, 2025 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants