-
Notifications
You must be signed in to change notification settings - Fork 275
feat: add Julia as a Semver ecosystem #4135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @mbauman, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces support for the Julia programming language ecosystem, treating its versioning scheme as Semantic Versioning. The change is minimal, adding 'Julia' to the ecosystem mapping in Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds support for the Julia ecosystem. The change is correct, but incomplete. I've added a comment with a suggestion to make the support for Julia more complete. Please review it.
|
Thanks for the PR! Please ignore gemini-bot's review there, we'll probably make it manually invoked from now on.
I think we still need it for parsing the purls though, as to do queries we convert the purls to to the list should be enough. |
Signed-off-by: Matt Bauman <mbauman@juliahub.com>
|
/gcbrun |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add some tests to the test_parse_purl section, since that is what the purl helper definition is will be mostly used for. You can put the uuid purls there to check that they are still parsed correctly.
Co-authored-by: Rex P <106129829+another-rex@users.noreply.github.com>
|
Great, added! |
|
/gcbrun |
|
Just need to run |
|
/gcbrun |
|
Test error should be fixed when we update our osv-schema submodule, no action required from your side :). |
|
Can you press the merge from main button? The tests should be passing after that. (Also, you can tick a box to give maintainers permission to push to the PR branch, and we can do the updating directly.) |
|
Yeah, I usually do check that box, but I think because this one came from a fork on our company org, we have that option turned off. I can't check it here. You are absolutely welcome to squash/cherry-pick/merge my work onto a branch of yours if that makes it any easier. |
|
/gcbrun |
No description provided.