Upgrade to source_gen 0.9.0 #154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pageloader can now be combined with other builders that want to output to `.g.dart` part files. - Upgrade to the latest buit_value_generator for compatibility. - Change the output extension to `.pageloader.g.part` following the new `source_gen` convention and apply the combining builder to get the `.g.dart`. - Remove the header option since it is no longer supported and move the extra ignores into the generator itself. - Override the `generate` method to prepend the ignores once instead of once per annotated element. - Regenerate all files. - Move `build_config` to normal dependencies since it is used to parse this package's `build.yaml` when used transitively.
|
Closes #153 ? |
kevmoo
approved these changes
Aug 1, 2018
|
I hadn't planned on doing anything with the quiver dep. That can probably be done in a separate PR |
|
ack
…On Wed, Aug 1, 2018 at 12:42 PM Nate Bosch ***@***.***> wrote:
I hadn't planned on doing anything with the quiver dep. That can probably
be done in a separate PR
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#154 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AABCisxshzcK-Y_O6BP2Mj4NaPwcyTaCks5uMgSTgaJpZM4VrFVn>
.
|
|
@kevmoo |
|
Please! @natebosch – can you rebase? |
|
Merged in master |
|
Is this ready to be submitted? |
|
Yes, this should be good to go |
|
Can this be merged soon, I'll need it to make the Angular example apps (and tests) fully Dart 2-final ready :) |
chalin
reviewed
Aug 6, 2018
| built_value: ^5.1.0 | ||
| matcher: ^0.12.0+1 | ||
| quiver: ^0.29.0 | ||
| source_gen: ^0.8.0 | ||
| source_gen: ^0.9.0 | ||
| webdriver: ^2.0.0-beta+1 |
There was a problem hiding this comment.
webdriver version will need to be updated too -- see google/webdriver.dart#205 (comment).
There was a problem hiding this comment.
Pending - google/webdriver.dart#206
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pageloader can now be combined with other builders that want to output
to
.g.dartpart files..pageloader.g.partfollowing the newsource_genconvention and apply the combining builder to get the.g.dart.extra ignores into the generator itself.
generatemethod to prepend the ignores once instead ofonce per annotated element.
build_configto normal dependencies since it is used to parsethis package's
build.yamlwhen used transitively.