-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to source_gen 0.9.0 #154
Conversation
pageloader can now be combined with other builders that want to output to `.g.dart` part files. - Upgrade to the latest buit_value_generator for compatibility. - Change the output extension to `.pageloader.g.part` following the new `source_gen` convention and apply the combining builder to get the `.g.dart`. - Remove the header option since it is no longer supported and move the extra ignores into the generator itself. - Override the `generate` method to prepend the ignores once instead of once per annotated element. - Regenerate all files. - Move `build_config` to normal dependencies since it is used to parse this package's `build.yaml` when used transitively.
Closes #153 ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you look at quiver, too?
I hadn't planned on doing anything with the quiver dep. That can probably be done in a separate PR |
ack
…On Wed, Aug 1, 2018 at 12:42 PM Nate Bosch ***@***.***> wrote:
I hadn't planned on doing anything with the quiver dep. That can probably
be done in a separate PR
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#154 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AABCisxshzcK-Y_O6BP2Mj4NaPwcyTaCks5uMgSTgaJpZM4VrFVn>
.
|
@kevmoo |
Please! @natebosch – can you rebase? |
Merged in master |
Is this ready to be submitted? |
Yes, this should be good to go |
Can this be merged soon, I'll need it to make the Angular example apps (and tests) fully Dart 2-final ready :) |
built_value: ^5.1.0 | ||
matcher: ^0.12.0+1 | ||
quiver: ^0.29.0 | ||
source_gen: ^0.8.0 | ||
source_gen: ^0.9.0 | ||
webdriver: ^2.0.0-beta+1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
webdriver
version will need to be updated too -- see google/webdriver.dart#205 (comment).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pending - google/webdriver.dart#206
pageloader can now be combined with other builders that want to output
to
.g.dart
part files..pageloader.g.part
following the newsource_gen
convention and apply the combining builder to get the.g.dart
.extra ignores into the generator itself.
generate
method to prepend the ignores once instead ofonce per annotated element.
build_config
to normal dependencies since it is used to parsethis package's
build.yaml
when used transitively.