Improve size checks #114
Merged
Improve size checks #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
hchataing
commented
Nov 8, 2024
hchataing
commented
- Remove support for partial parent derivation
- Implement analyzer checks for field size and offsets
The following pattern is currently only supported
by the Python generator, and will no longer be officially
supported going forward
```
struct Parent {
a : 1, // no an octet size
_payload_,
}
struct Child : Parent (a = 0) {
b : 7,
// other fields
}
```
Validate that non-bitfield fields do start on an octet boundary, and that packet and structs have a size that is an integral number of octets. Fixes #33
hchataing
force-pushed
the
size-checks
branch
from
30f197a to
68e6165
Compare
mgeisler
reviewed
Nov 8, 2024
mgeisler
reviewed
Nov 8, 2024
mgeisler
reviewed
Nov 8, 2024
mgeisler
approved these changes
Nov 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.