Revert "Skip app/vendors from compilemessages #763" PR #765 #768
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 0af534c. --ignore option for compilemessages is supported in greater than django 3.0. https://docs.djangoproject.com/en/3.1/ref/django-admin/#cmdoption-compilemessages-ignore makemessages support --ignore even on django 1.x https://docs.djangoproject.com/en/3.1/ref/django-admin/#cmdoption-makemessages-ignore Indeed, our django version is 1.11.29, which is the last version for Python 2.x Django 1.11 is the last version to support Python 2.7. Support for Python 2.7 and Django 1.11 ends in 2020. https://docs.djangoproject.com/en/3.1/faq/install/
|
Merged, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 0af534c.
--ignore option for compilemessages is supported in greater than django 3.0.
https://docs.djangoproject.com/en/3.1/ref/django-admin/#cmdoption-compilemessages-ignore
makemessages support --ignore even on django 1.x
https://docs.djangoproject.com/en/3.1/ref/django-admin/#cmdoption-makemessages-ignore
Indeed, our django version is 1.11.29, which is the last version for Python 2.x
Django 1.11 is the last version to support Python 2.7. Support for Python 2.7 and Django 1.11 ends in 2020.
https://docs.djangoproject.com/en/3.1/faq/install/
As a result of adding the option to compilemessages, tools/update_messages started to fail with exit code of 2.
Based on an internal sync, we decided to keep the change on hold until we migrate the project to Python 3 (and consequently migrate django to 3.x as well).
This PR is a correction of #767.